slfan1989 commented on code in PR #6390:
URL: https://github.com/apache/hadoop/pull/6390#discussion_r1440105699
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java:
##########
@@ -116,7 +116,7 @@ public class StateStoreService extends CompositeService {
/** Service to maintain State Store caches. */
private StateStoreCacheUpdateService cacheUpdater;
/** Time the cache was last successfully updated. */
- private long cacheLastUpdateTime;
+ private long cacheLastUpdateTime = 0;
Review Comment:
Thanks for the explanation! But the code looks weird because other variables
are initialized in the constructor, can we initialize to `0` in the
constructor? Just a personal opinion, let's wait goiri's view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
