ayushtkn commented on code in PR #6402:
URL: https://github.com/apache/hadoop/pull/6402#discussion_r1440351242
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##########
@@ -306,7 +306,7 @@ int run(List<String> args) throws IOException {
new BufferedOutputStream(Files.newOutputStream(srcMeta.toPath()),
smallBufferSize));
BlockMetadataHeader.writeHeader(metaOut, checksum);
- metaOut.close();
+ metaOut.flush();
Review Comment:
I think close itself is ok, we can avoid closing in the finally block if the
stream is already closing, rather than flushing here & then closing below,
close would be calling flush before closing itself.
in general I don't think it isn't a big problem, maybe just dereference the
metaOut after close
```
metaOut.close();
metaOut = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
