simbadzina commented on PR #6404: URL: https://github.com/apache/hadoop/pull/6404#issuecomment-1877871135
> > I'm wondering if we can instead fix the existing mechanism such that only a single read is sent to the active, vs. adding a new mechanism. > > Yes, it can. But for only a single read is send to the active, we should add synchronized. And this maybe have performance impact. Add a seperate RouterAutoMsyncService maybe a way to slove it. > > > Additionally, the periodic redirection of calls to the active only happens in the case when there are no calls going to the active already so having some reads be sent to the active should not overload it. > > In most cases, that's true. But I think add RouterAutoMsyncService will be more robustness. Thanks That is fair. I'll take a closer look at the implementation now that we've discussed the higher level details. Please also address the unit test comment by @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
