mukund-thakur commented on code in PR #6022:
URL: https://github.com/apache/hadoop/pull/6022#discussion_r1443395651
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -324,14 +328,26 @@ public void sendRequest(byte[] buffer, int offset, int
length) throws IOExceptio
*/
outputStream = getConnOutputStream();
} catch (IOException e) {
- /* If getOutputStream fails with an exception and expect header
- is enabled, we return back without throwing an exception to
- the caller. The caller is responsible for setting the correct
status code.
- If expect header is not enabled, we throw back the exception.
+ connectionDisconnectedOnError = true;
Review Comment:
setting this field here and using in processResponse() means that we won't
be processing response for any IOException. But isn't the intent to not process
only in case of JDK error?
So shouldn't this go inside the if
(EXPECT_100_JDK_ERROR.equals(e.getMessage().......) check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
