huangzhaobo99 commented on PR #6411: URL: https://github.com/apache/hadoop/pull/6411#issuecomment-1879630235
> Spotbugs Report shows 2 Spotbugs: > > * The first one is caused by [YARN-11634](https://issues.apache.org/jira/browse/YARN-11634)([YARN-11634. Speed-up TestTimelineClient #6371](https://github.com/apache/hadoop/pull/6371)). I submitted a fix PR([YARN-11634. [Addendum] Speed-up TestTimelineClient. #6419](https://github.com/apache/hadoop/pull/6419)). > > ``` > Code Warning > MS org.apache.hadoop.yarn.client.api.impl.TimelineConnector.DEFAULT_SOCKET_TIMEOUT isn't final but should be > [Bug type MS_SHOULD_BE_FINAL (click for details)](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6411/1/artifact/out/branch-spotbugs-root-warnings.html#MS_SHOULD_BE_FINAL) > In class org.apache.hadoop.yarn.client.api.impl.TimelineConnector > Field org.apache.hadoop.yarn.client.api.impl.TimelineConnector.DEFAULT_SOCKET_TIMEOUT > At TimelineConnector.java:[line 82] > ``` > > * The second one is because there is an invalid code in NN. > > ``` > Code Warning > DLS Dead store to sharedDirs in org.apache.hadoop.hdfs.server.namenode.NameNode.format(Configuration, boolean, boolean) > [Bug type DLS_DEAD_LOCAL_STORE (click for details)](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6411/1/artifact/out/branch-spotbugs-root-warnings.html#DLS_DEAD_LOCAL_STORE) > In class org.apache.hadoop.hdfs.server.namenode.NameNode > In method org.apache.hadoop.hdfs.server.namenode.NameNode.format(Configuration, boolean, boolean) > Local variable named sharedDirs > At NameNode.java:[line 1383] > ``` @slfan1989 The second warning has been fixed: https://issues.apache.org/jira/browse/HDFS-17315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
