[ 
https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804129#comment-17804129
 ] 

Viraj Jasani commented on HADOOP-19022:
---------------------------------------

 
{quote}have you explicitly set it in your site config?
{quote}
Can confirm that it is not set explicitly, this test fails consistently because 
it takes 120 as 120 ms by default, and since it is less than 15 s, so 15s is 
selected:

 
{code:java}
apiCallTimeout = enforceMinimumDuration(REQUEST_TIMEOUT,
    apiCallTimeout, minimumOperationDuration); {code}
Here, minimumOperationDuration is 15s.

 

 

For this Jira, we can
 # Make the test use "120s" instead of "120" so that it will not set 15s by 
default.
 # Add a test with timeout value smaller than 15s and verify that actual 
timeout in S3A client config object is 15s.
 # Add a test by setting "0" as timeout and verify that 
SdkClientOption.API_CALL_ATTEMPT_TIMEOUT does not even get set.
 # Document "fs.s3a.connection.request.timeout" as having 15s default behavior 
if any client sets it with value > 0 and < 15s.

WDYT?

> S3A : ITestS3AConfiguration#testRequestTimeout failure
> ------------------------------------------------------
>
>                 Key: HADOOP-19022
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19022
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: 3.4.0
>            Reporter: Viraj Jasani
>            Priority: Minor
>
> "fs.s3a.connection.request.timeout" should be specified in milliseconds as per
> {code:java}
> Duration apiCallTimeout = getDuration(conf, REQUEST_TIMEOUT,
>     DEFAULT_REQUEST_TIMEOUT_DURATION, TimeUnit.MILLISECONDS, Duration.ZERO); 
> {code}
> The test fails consistently because it sets 120 ms timeout which is less than 
> 15s (min network operation duration), and hence gets reset to 15000 ms based 
> on the enforcement.
>  
> {code:java}
> [ERROR] testRequestTimeout(org.apache.hadoop.fs.s3a.ITestS3AConfiguration)  
> Time elapsed: 0.016 s  <<< FAILURE!
> java.lang.AssertionError: Configured fs.s3a.connection.request.timeout is 
> different than what AWS sdk configuration uses internally expected:<120000> 
> but was:<15000>
>       at org.junit.Assert.fail(Assert.java:89)
>       at org.junit.Assert.failNotEquals(Assert.java:835)
>       at org.junit.Assert.assertEquals(Assert.java:647)
>       at 
> org.apache.hadoop.fs.s3a.ITestS3AConfiguration.testRequestTimeout(ITestS3AConfiguration.java:444)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to