mukund-thakur commented on code in PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#discussion_r1445484838
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java:
##########
@@ -209,6 +210,9 @@ protected Map<Class<? extends Exception>, RetryPolicy>
createExceptionMap() {
// in this map.
policyMap.put(AWSClientIOException.class, retryAwsClientExceptions);
+ // Http Channel issues: treat as communication failure
+ policyMap.put(AwsHttpChannelException.class, connectivityFailure);
Review Comment:
the changes looks good to me. It's just when I commented this line, I was
expecting the tests to fail but they don't.
Because IOE's are always retried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
