bpahuja commented on PR #6407: URL: https://github.com/apache/hadoop/pull/6407#issuecomment-1899812388
> most of my comments are on the basic stuff, especially those test assertions and the need to have a single factored out assertion() method. Am converting the current test into an ITest, will update assertions according to the recommendations > Now, can we have the storage class an attribute in S3AFileStatus? populated in listings and from HEAD requests? included in .toString()? that could be useful in future This is something that can be done, do we want this as part of this PR ? Or a separate one adding the storage class to S3AFileStatus ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
