tmnd1991 commented on PR #6301: URL: https://github.com/apache/hadoop/pull/6301#issuecomment-1900429593
So finally I go the final "push" on this. I was able to verify my tests pass through running locally: `mvn -pl hadoop-tools/hadoop-aws verify -Dit.test=ITestS3AFileSystemIsolatedClassloader -Dtest=none` while running `mvn -pl hadoop-tools/hadoop-aws clean verify` lead to 40ish errors/failures that to my eyes look completely unrelated to this patch. I will wait for yetus results in order to see if I've left anything behind :) Maybe the last thing that I might do to improve this is to make it a unit test instead of an integration one, but given [your comment](https://github.com/apache/hadoop/pull/6301#discussion_r1407732777) I guess given the fact that instantiates and fs it must be an IT test and I can't think a way of testing this without instantiating the fs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
