[ 
https://issues.apache.org/jira/browse/HADOOP-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242677#comment-13242677
 ] 

Todd Lipcon commented on HADOOP-8228:
-------------------------------------

bq. One question: are you positive that the ordering of the two @After methods 
either doesn't matter, or is guaranteed to happen in the right order?

The order of the two @After methods is nondeterministic. But, in this case, 
it's only important that our @After method runs before the superclass 
(ClientBase)'s tearDown. JUnit does guarantee the ordering in this case.

bq. One comment: maybe use a deterministic random seed for the Random instances 
you're using? Or at least log the amount of time that the test is sleeping for 
and what it's throwing?
Good point. I added additional logging for when it throws exceptions, and for 
when it expires sessions. I don't think the deterministic seed helps things, 
since the interleaving is still non-deterministic (that's part of the value of 
these tests :) )
                
> Auto HA: Refactor tests and add stress tests
> --------------------------------------------
>
>                 Key: HADOOP-8228
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8228
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: auto-failover, ha, test
>    Affects Versions: Auto Failover (HDFS-3042)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8228.txt, hadoop-8228.txt, hadoop-8228.txt
>
>
> It's important that the ZKFailoverController be robust and not contain race 
> conditions, etc. One strategy to find potential races is to add stress tests 
> which exercise the code as fast as possible. This JIRA is to implement some 
> test cases of this style.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to