adnanhemani commented on code in PR #6507:
URL: https://github.com/apache/hadoop/pull/6507#discussion_r1473617958
##########
hadoop-tools/hadoop-aws/pom.xml:
##########
@@ -508,6 +508,29 @@
<artifactId>bundle</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>software.amazon.s3.accessgrants</groupId>
Review Comment:
This new JAR should be optional - and as per the original instructions the
AWS S3 Access Grants team was given by the AWS Java SDK team, this plugin
should not be part of the AWS Java SDK nor the SDK bundle. The reasoning behind
this was that Java SDKv2 Plugins should be considered as "open source" for the
most part as they are only interfaces that anyone can implement and then use
wherever they'd like. In other words, the S3 Access Grants plugin should be, in
theory, treated as any other open source dependency that we would be utilizing
if a customer explicitly enables this in S3A.
So, to further answer the question, we need to find a way to optionally load
these classes if a user specifies that they'd like to use the plugin AND
provides the JAR on the classpath. That is missing from this PR as of now and
@jxhan3 and I will work on it. I think @ahmarsuhail's [link
above](https://github.com/apache/hadoop/pull/6507#discussion_r1472930404) has a
good call pattern for doing this - we'll follow this unless you have any other
suggestion.
One interesting thing to note - I've seen the `S3ExpressPlugin` being merged
into the AWS Java SDK (which was explicitly not the recommended option by the
AWS Java SDK team, per my understanding). I've started further inquiries to
find why that's the case - and how this is different than S3 Access Grants.
Will report my findings here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
