[
https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813454#comment-17813454
]
ASF GitHub Bot commented on HADOOP-19044:
-----------------------------------------
virajjasani commented on code in PR #6479:
URL: https://github.com/apache/hadoop/pull/6479#discussion_r1475408178
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -228,6 +228,8 @@ If you do any of these: change your credentials immediately!
See [Connecting to an Amazon S3 Bucket through the S3A
Connector](connecting.md).
Review Comment:
done
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java:
##########
@@ -345,8 +385,27 @@ private void assertOpsUsingNewFs() throws IOException {
out.write(new byte[] {1, 2, 3});
}
- ContractTestUtils.assertIsFile(getFileSystem(), srcFilePath);
- ContractTestUtils.assertIsFile(newFS, srcFilePath);
+ Assertions
+ .assertThat(newFS.exists(srcFilePath))
+ .describedAs("Existence of file: " + srcFilePath)
+ .isTrue();
+ Assertions
+ .assertThat(getFileSystem().exists(srcFilePath))
+ .describedAs("Existence of file: " + srcFilePath)
+ .isTrue();
+
+ byte[] buffer = new byte[3];
+
+ try (FSDataInputStream in = newFS.open(srcFilePath)) {
+ Assertions
+ .assertThat(in.read(buffer, 0, 3))
Review Comment:
done
> AWS SDK V2 - Update S3A region logic
> -------------------------------------
>
> Key: HADOOP-19044
> URL: https://issues.apache.org/jira/browse/HADOOP-19044
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Ahmar Suhail
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> If both fs.s3a.endpoint & fs.s3a.endpoint.region are empty, Spark will set
> fs.s3a.endpoint to
> s3.amazonaws.com here:
> [https://github.com/apache/spark/blob/9a2f39318e3af8b3817dc5e4baf52e548d82063c/core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala#L540]
>
>
> HADOOP-18908, updated the region logic such that if fs.s3a.endpoint.region is
> set, or if a region can be parsed from fs.s3a.endpoint (which will happen in
> this case, region will be US_EAST_1), cross region access is not enabled.
> This will cause 400 errors if the bucket is not in US_EAST_1.
>
> Proposed: Updated the logic so that if the endpoint is the global
> s3.amazonaws.com , cross region access is enabled.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
