[
https://issues.apache.org/jira/browse/HADOOP-18987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813584#comment-17813584
]
ASF GitHub Bot commented on HADOOP-18987:
-----------------------------------------
DieterDP-ng commented on code in PR #6292:
URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475781381
##########
hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md:
##########
@@ -432,7 +432,7 @@ of data which must be collected in a single RPC call.
#### Preconditions
- exists(FS, path) else raise FileNotFoundException
+ if not exists(FS, path) : raise FileNotFoundException
Review Comment:
Either form is understandable imo, just thought the suggested form is more
in line with the remainder of the docs which uses pythonesque code.
> Corrections to Hadoop FileSystem API Definition
> -----------------------------------------------
>
> Key: HADOOP-18987
> URL: https://issues.apache.org/jira/browse/HADOOP-18987
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 3.3.6
> Reporter: Dieter De Paepe
> Assignee: Dieter De Paepe
> Priority: Minor
> Labels: pull-request-available
>
> I noticed a lot of inconsistencies, typos and informal statements in the
> "formal" FileSystem API definition
> ([https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/filesystem/index.html)]
> Creating this ticket to link my PR against.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
