simbadzina commented on PR #6519: URL: https://github.com/apache/hadoop/pull/6519#issuecomment-1924475554
Change LGTM. It there a way to test this, that isn't too complicated. One path I see to get an exception from `Thread.start()` is calling it twice. The second call will throw `IllegalThreadStateException()`. So you can start `rpcRequestThread` before `Connection.run()` and then validate that the Connection is immediately marked as closed. I'm +1 without the test though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
