slfan1989 commented on code in PR #6531:
URL: https://github.com/apache/hadoop/pull/6531#discussion_r1480648680
##########
hadoop-project/pom.xml:
##########
@@ -168,7 +168,18 @@
<enforced.maven.version>[3.3.0,)</enforced.maven.version>
<!-- Plugin versions and config -->
- <maven-surefire-plugin.argLine>-Xmx2048m
-XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
+ <maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
Review Comment:
Thank you very much for submitting this PR. We are looking forward to Hadoop
supporting JDK11 and JDK17.
I have some questions:
Should we fully support JDK11 and JDK17, or should we try to avoid certain
issues by adding some compilation parameters?
From my perspective, we should find ways to upgrade the code and make all
modules fully compatible with the recommended syntax of JDK11 and JDK17.
@aajisaka @ayushtkn @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
