[
https://issues.apache.org/jira/browse/HADOOP-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817474#comment-17817474
]
ASF GitHub Bot commented on HADOOP-19057:
-----------------------------------------
hadoop-yetus commented on PR #6548:
URL: https://github.com/apache/hadoop/pull/6548#issuecomment-1944338608
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 22s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 18 new or modified test files. |
|||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 0s | | branch-3.3 passed |
| +1 :green_heart: | compile | 0m 25s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 0m 20s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 0m 32s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 0m 27s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 0m 49s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 23m 15s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 26s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 13s | | hadoop-tools/hadoop-aws:
The patch generated 0 new + 18 unchanged - 1 fixed = 18 total (was 19) |
| +1 :green_heart: | mvnsite | 0m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 47s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 45s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 48s | | hadoop-aws in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 24s | | The patch does not
generate ASF License warnings. |
| | | 88m 41s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6548/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6548 |
| Optional Tests | dupname asflicense mvnsite codespell detsecrets
markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs
checkstyle xmllint |
| uname | Linux c1dab86f5142 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / feb4a2c015ba3f1ace7bd36bff9fce2dbd720db1 |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6548/2/testReport/ |
| Max. process+thread count | 551 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6548/2/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> S3 public test bucket landsat-pds unreadable -needs replacement
> ---------------------------------------------------------------
>
> Key: HADOOP-19057
> URL: https://issues.apache.org/jira/browse/HADOOP-19057
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.4.0, 3.2.4, 3.3.9, 3.3.6, 3.5.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.5.0, 3.4.1
>
>
> The s3 test bucket used in hadoop-aws tests of S3 select and large file reads
> is no longer publicly accessible
> {code}
> java.nio.file.AccessDeniedException: landsat-pds: getBucketMetadata() on
> landsat-pds: software.amazon.awssdk.services.s3.model.S3Exception: null
> (Service: S3, Status Code: 403, Request ID: 06QNYQ9GND5STQ2S, Extended
> Request ID:
> O+u2Y1MrCQuuSYGKRAWHj/5LcDLuaFS8owNuXXWSJ0zFXYfuCaTVLEP351S/umti558eKlUqV6U=):null
> {code}
> * Because HADOOP-18830 has cut s3 select, all we need in 3.4.1+ is a large
> file for some reading tests
> * changing the default value disables s3 select tests on older releases
> * if fs.s3a.scale.test.csvfile is set to " " then other tests which need it
> will be skipped
> Proposed
> * we locate a new large file under the (requester pays) s3a://usgs-landsat/
> bucket . All releases with HADOOP-18168 can use this
> * update 3.4.1 source to use this; document it
> * do something similar for 3.3.9 + maybe even cut s3 select there too.
> * document how to use it on older releases with requester-pays support
> * document how to completely disable it on older releases.
> h2. How to fix (most) landsat test failures on older releases
> add this to your auth-keys.xml file. Expect some failures in a few tests
> with-hardcoded references to the bucket (assumed role delegation tokens)
> {code}
> <property>
> <name>fs.s3a.scale.test.csvfile</name>
> <value>s3a://noaa-cors-pds/raw/2023/017/ohfh/OHFH017d.23_.gz</value>
> <description>file used in scale tests</description>
> </property>
> <property>
> <name>fs.s3a.bucket.noaa-cors-pds.endpoint.region</name>
> <value>us-east-1</value>
> </property>
> <property>
> <name>fs.s3a.bucket.noaa-isd-pds.multipart.purge</name>
> <value>false</value>
> <description>Don't try to purge uploads in the read-only bucket, as
> it will only create log noise.</description>
> </property>
> <property>
> <name>fs.s3a.bucket.noaa-isd-pds.probe</name>
> <value>0</value>
> <description>Let's postpone existence checks to the first IO operation
> </description>
> </property>
> <property>
> <name>fs.s3a.bucket.noaa-isd-pds.audit.add.referrer.header</name>
> <value>false</value>
> <description>Do not add the referrer header</description>
> </property>
> <property>
> <name>fs.s3a.bucket.noaa-isd-pds.prefetch.block.size</name>
> <value>128k</value>
> <description>Use a small prefetch size so tests fetch multiple
> blocks</description>
> </property>
> <property>
> <name>fs.s3a.select.enabled</name>
> <value>false</value>
> </property>
> {code}
> Some delegation token tests will still fail; these have hard-coded references
> to the old bucket. *Do not worry about these*
> {code}
> [ERROR] ITestDelegatedMRJob.testJobSubmissionCollectsTokens[0] »
> AccessDenied s3a://la...
> [ERROR] ITestDelegatedMRJob.testJobSubmissionCollectsTokens[1] »
> AccessDenied s3a://la...
> [ERROR] ITestDelegatedMRJob.testJobSubmissionCollectsTokens[2] »
> AccessDenied s3a://la...
> [ERROR]
> ITestRoleDelegationInFilesystem>ITestSessionDelegationInFilesystem.testDelegatedFileSystem:347->ITestSessionDelegationInFilesystem.readLandsatMetadata:614
> » AccessDenied
> [ERROR]
> ITestSessionDelegationInFilesystem.testDelegatedFileSystem:347->readLandsatMetadata:614
> » AccessDenied
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
