[
https://issues.apache.org/jira/browse/HADOOP-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817505#comment-17817505
]
Steve Loughran commented on HADOOP-16318:
-----------------------------------------
Looks like a lot of the code has been done; it just fell by the wayside. so
take it up -we will credit you and the author of the original patch.
regarding the change
I really don't like the way junit5 seems to require as to rewrite every single
test assertion.
It's like we're being punished for writing lots of tests, or more specifically:
test with meaningful errors.
And it'll make cherrypicking any change in a test from a v5 to a v4 branch
really hard.
Proposed.
* add the pom change as a self contained patch.
* For any assertion change which would require reordering of arguments to
assertTrue/assertEquals/assertSame, *move to assertJ*. that way, works across
all versions.
* for those where assert true/equals just needs to be with the new static
import, go as is. easily backported.
I'm also wondering whether we should hava a junit5 version of
AbstractHadoopTestBase, e.g AbstractJupiterTestBase which does the timeout and
thread naming; all test suites without a superclass can extend this and avoid
adding it themselves.
Can anyone see a problem with this?
> Upgrade JUnit from 4 to 5 in hadoop security
> --------------------------------------------
>
> Key: HADOOP-16318
> URL: https://issues.apache.org/jira/browse/HADOOP-16318
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Ashutosh Gupta
> Priority: Major
> Attachments: HDFS-12433.001.patch, HDFS-12433.002.patch
>
>
> Upgrade JUnit from 4 to 5 in hadoop security (org.apache.hadoop.security)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
