steveloughran commented on code in PR #6543:
URL: https://github.com/apache/hadoop/pull/6543#discussion_r1490982845
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MkdirOperation.java:
##########
@@ -73,11 +79,13 @@ public MkdirOperation(
final StoreContext storeContext,
final Path dir,
final MkdirCallbacks callbacks,
- final boolean isMagicPath) {
+ final boolean isMagicPath,
Review Comment:
actually, these should be the same flag. so rename it performanceCreation
and in s3aFS set to true if the path is magic or `performanceCreation` is true.
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MkdirOperation.java:
##########
@@ -124,7 +132,32 @@ public Boolean execute() throws IOException {
return true;
}
- // Walk path to root, ensuring closest ancestor is a directory, not file
+ // if performance creation mode is set, no need to check
Review Comment:
how about on L116 we only do a HEAD check for the path without /, (maybe
need new callback), so no LIST probe for a dir via HEAD/LIST
```
S3AFileStatus fileStatus = performanceCreation
? probePathStatusOrNull(dir, StatusProbeEnum.Head)
? getPathStatusExpectingDir(dir);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
