haiyang1987 commented on code in PR #6508:
URL: https://github.com/apache/hadoop/pull/6508#discussion_r1492085929
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java:
##########
@@ -56,52 +66,72 @@ public QueryCommand(Configuration conf) {
@Override
public void execute(CommandLine cmd) throws Exception {
LOG.info("Executing \"query plan\" command.");
+ TextStringBuilder result = new TextStringBuilder();
Preconditions.checkState(cmd.hasOption(DiskBalancerCLI.QUERY));
verifyCommandOptions(DiskBalancerCLI.QUERY, cmd);
- String nodeName = cmd.getOptionValue(DiskBalancerCLI.QUERY);
- Preconditions.checkNotNull(nodeName);
- nodeName = nodeName.trim();
- String nodeAddress = nodeName;
-
- // if the string is not name:port format use the default port.
- if (!nodeName.matches("[^\\:]+:[0-9]{2,5}")) {
- int defaultIPC = NetUtils.createSocketAddr(
- getConf().getTrimmed(DFSConfigKeys.DFS_DATANODE_IPC_ADDRESS_KEY,
- DFSConfigKeys.DFS_DATANODE_IPC_ADDRESS_DEFAULT)).getPort();
- nodeAddress = nodeName + ":" + defaultIPC;
- LOG.debug("Using default data node port : {}", nodeAddress);
+ String nodeVal = cmd.getOptionValue(DiskBalancerCLI.QUERY);
+ Preconditions.checkNotNull(nodeVal);
+ nodeVal = nodeVal.trim();
+ Set<String> resultSet = new TreeSet<>();
+ String[] nodes = nodeVal.split(",");
+ if (nodes.length == 0) {
Review Comment:
Modify patch based on comments.
Hi @tasanuma please help review it again, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
