[
https://issues.apache.org/jira/browse/HADOOP-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246652#comment-13246652
]
Hadoop QA commented on HADOOP-6963:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521370/HADOOP-6963.branch-23.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/819//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/819//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/819//console
This message is automatically generated.
> Fix FileUtil.getDU. It should not include the size of the directory or follow
> symbolic links
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-6963
> URL: https://issues.apache.org/jira/browse/HADOOP-6963
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.205.0, 0.23.1
> Reporter: Owen O'Malley
> Assignee: Ravi Prakash
> Priority: Critical
> Attachments: HADOOP-6963.branch-1.0.2.patch,
> HADOOP-6963.branch-23.patch, HADOOP-6963.branch-23.patch
>
>
> The getDU method should not include the size of the directory. The Java
> interface says that the value is undefined and in Linux/Sun it gets the 4096
> for the inode. Clearly this isn't useful.
> It also recursively calls itself. In case the directory has a symbolic link
> forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this
> in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects
> call. This prevented other tasks on the same node from committing, causing
> the TT to become effectively useless (because the JT thinks it already has
> enough tasks running)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
