[
https://issues.apache.org/jira/browse/HADOOP-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246660#comment-13246660
]
Robert Joseph Evans commented on HADOOP-8179:
---------------------------------------------
The patch looks simple enough that no unit tests are needed and it fixes the
observed issue. +1
> risk of NPE in CopyCommands processArguments()
> ----------------------------------------------
>
> Key: HADOOP-8179
> URL: https://issues.apache.org/jira/browse/HADOOP-8179
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.2, 0.24.0
> Reporter: Steve Loughran
> Assignee: Daryn Sharp
> Priority: Minor
> Attachments: HADOOP-8179.patch, HADOOP-8179.patch
>
>
> My IDE is warning me that the {{is.close()}} method will NPE if the {{is =
> src.fs.open(src.path);}} call raises an exception, which could happen if the
> source path could not be opened. There should be an if (is!=null) wrapper
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira