anujmodi2021 commented on code in PR #6552:
URL: https://github.com/apache/hadoop/pull/6552#discussion_r1497039338
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -332,6 +335,8 @@ public AbfsRestOperation setFilesystemProperties(final
String properties,
final AbfsUriQueryBuilder abfsUriQueryBuilder =
createDefaultUriQueryBuilder();
abfsUriQueryBuilder.addQuery(QUERY_PARAM_RESOURCE, FILESYSTEM);
+ appendSASTokenToQuery(ROOT_PATH, "", abfsUriQueryBuilder);
Review Comment:
Nice Catch. Operations name added for file system level operations as well.
Just FYI
The purpose of having operation name here is to determine what all
permissions are needed to be set in SAS Token generated. It is up to the custom
SAS Token Provider Implementation to use this information and set appropriate
permissions. For Example, MockDelegationSASTokenProvider does not allow file
system level operations hence it will error out for these operations with
SASTokenProviderException.
Where as AccountSASGenerator will have fixed permissions irrespective of
operation type.
Operation Name are added here so that if a user wants to define their own
implementation, they can choose to consume this information as per their needs
and logic. They can also choose to simply ignore them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
