tasanuma commented on code in PR #6517:
URL: https://github.com/apache/hadoop/pull/6517#discussion_r1502860434


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -3908,6 +3908,18 @@
   </description>
 </property>
 
+<property>
+  <name>dfs.client.ec.EXAMPLEECPOLICYNAME.checkstreamer.redunency</name>

Review Comment:
   @hfutatzhanghb  Thanks for the PR. I think it's a good feature.
   
   In my honest opinion, 
`dfs.client.ec.EXAMPLEECPOLICYNAME.checkstreamer.redunency` is 
counter-intuitive. I prefer a setting that interprets values in a reverse way. 
In other words, it would be something like 
`dfs.client.ec.EXAMPLEECPOLICYNAME.failed.write.block.tolerated`, where if the 
value is 0, then no failures are tolerated. And if it's 3, we can tolerate up 
to 3 failures in block writing. If the setting value is empty (it would be 
default), we can tolerate failures up to the number of parity blocks. This is 
just my personal view.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to