[
https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820791#comment-17820791
]
ASF GitHub Bot commented on HADOOP-18708:
-----------------------------------------
steveloughran commented on code in PR #6164:
URL: https://github.com/apache/hadoop/pull/6164#discussion_r1503019354
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/ErrorTranslation.java:
##########
@@ -152,6 +156,25 @@ public static IOException maybeExtractIOException(
return wrapWithInnerIOE(path, message, thrown, ioe);
}
+ /**
+ * Extracts the underlying exception from a SdkException.
+ * @param exception amazon exception raised
+ * @return extractedException
+ */
+ public static SdkException maybeExtractSdkException(SdkException exception) {
Review Comment:
how about "maybeExtractInnerSdkException()"
##########
hadoop-project/pom.xml:
##########
@@ -1149,6 +1150,17 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>software.amazon.encryption.s3</groupId>
Review Comment:
is this going to get into bundle.jar?
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/ErrorTranslation.java:
##########
@@ -152,6 +156,25 @@ public static IOException maybeExtractIOException(
return wrapWithInnerIOE(path, message, thrown, ioe);
}
+ /**
+ * Extracts the underlying exception from a SdkException.
+ * @param exception amazon exception raised
+ * @return extractedException
+ */
+ public static SdkException maybeExtractSdkException(SdkException exception) {
+ SdkException extractedException = exception;
+ if (exception.toString().contains(ENCRYPTION_CLIENT_EXCEPTION)
+ && exception.getCause() instanceof SdkException) {
Review Comment:
lets put this at the top and return null immediately; lines up for adding
more probes.
> AWS SDK V2 - Implement CSE
> --------------------------
>
> Key: HADOOP-18708
> URL: https://issues.apache.org/jira/browse/HADOOP-18708
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Ahmar Suhail
> Assignee: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
>
> S3 Encryption client for SDK V2 is now available, so add client side
> encryption back in.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
