[
https://issues.apache.org/jira/browse/HADOOP-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822027#comment-17822027
]
ASF GitHub Bot commented on HADOOP-19089:
-----------------------------------------
saxenapranav commented on code in PR #6592:
URL: https://github.com/apache/hadoop/pull/6592#discussion_r1502450811
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAttributes.java:
##########
@@ -91,13 +90,6 @@ public void testSetGetXAttrReplace() throws Exception {
.containsExactly(attributeValue2);
}
- @Test
- public void testGetSetXAttrOnRoot() throws Exception {
- AzureBlobFileSystem fs = getFileSystem();
- final Path testPath = new Path("/");
- testGetSetXAttrHelper(fs, testPath);
Review Comment:
To prevent revert add of getFileSystemProperties and setFileSystemProperties
for getXAttr / setXAttr in future, should we not remove this method, and
additionally assert that the getFileSystemProperties and
setFileSystemProperties of store are not called, but setPathProperties and
getPathStatus of store is called..
> [ABFS] Reverting Back Support of setXAttr() and getXAttr() on root path
> -----------------------------------------------------------------------
>
> Key: HADOOP-19089
> URL: https://issues.apache.org/jira/browse/HADOOP-19089
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> A while back changes were made to support HDFS.setXAttr() and HDFS.getXAttr()
> on root path for ABFS Driver.
> For these, filesystem level APIs were introduced and used to set/get metadata
> of container.
> Refer to Jira: [HADOOP-18869] ABFS: Fixing Behavior of a File System APIs on
> root path - ASF JIRA (apache.org)
> Ideally, same set of APIs should be used, and root should be treated as a
> path like any other path.
> This change is to avoid calling container APIs for these HDFS calls.
> As a result of this these APIs will fail on root path (as earlier) because
> service does not support get/set of user properties on root path.
> This change will also update the documentation to reflect that these
> operations are not supported on root path.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
