steveloughran commented on code in PR #6584: URL: https://github.com/apache/hadoop/pull/6584#discussion_r1508958305
########## hadoop-hdfs-project/hadoop-hdfs/pom.xml: ########## @@ -35,6 +35,17 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> </properties> <dependencies> + <dependency> + <groupId>log4j</groupId> + <artifactId>apache-log4j-extras</artifactId> + <version>${log4j-extras.version}</version> + <exclusions> Review Comment: what else comes in as a dependency ########## hadoop-hdfs-project/hadoop-hdfs/pom.xml: ########## @@ -35,6 +35,17 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> </properties> <dependencies> + <dependency> + <groupId>log4j</groupId> + <artifactId>apache-log4j-extras</artifactId> + <version>${log4j-extras.version}</version> Review Comment: declare this in hadoop-project pom with version and exclusions, then declare in this file without those. this is to ensure consistent importing across different modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
