Jtdellaringa commented on code in PR #6598:
URL: https://github.com/apache/hadoop/pull/6598#discussion_r1509756204
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java:
##########
@@ -221,12 +225,16 @@ private synchronized void removeExpiredKeys() {
/**
* Set block keys, only to be used in worker mode
*/
- public synchronized void addKeys(ExportedBlockKeys exportedKeys)
+ public synchronized void addKeys(ExportedBlockKeys exportedKeys,
Optional<InetSocketAddress> nnAddr)
throws IOException {
if (isMaster || exportedKeys == null) {
return;
}
- LOG.info("Setting block keys. BlockPool = {} .", blockPoolId);
+ if (nnAddr.isPresent()) {
+ LOG.info("Setting block keys. BlockPool = {} . Namenode Address = {} .",
blockPoolId, nnAddr);
Review Comment:
Discussed and will not go forward with this approach due to BPServiceActor
being private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
