shahrs87 commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1979352026
1. [spotbugs](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html) warning is not related to patch. So ignoring for now. 2. There are 3 test failures, 2 of them ([TestBlockListAsLongs.testFuzz](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/testReport/junit/org.apache.hadoop.hdfs.protocol/TestBlockListAsLongs/testFuzz/) and [TestLargeBlockReport.testBlockReportSucceedsWithLargerLengthLimit](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/testReport/junit/org.apache.hadoop.hdfs.server.datanode/TestLargeBlockReport/testBlockReportSucceedsWithLargerLengthLimit/)) are consistently failing in nightly builds. 3. The third test failure ([TestDFSAdmin.testDecommissionDataNodesReconfig](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/testReport/junit/org.apache.hadoop.hdfs.tools/TestDFSAdmin/testDecommissionDataNodesReconfig/)) is flaky. Created [HDFS-17409](https://issues.apache.org/jira/browse/HDFS-17409) for further investigation. This PR is ready to review again. All the comments are addressed by @ritegarg. If there are no more comment by EOD tomorrow, I will merge this PR. Cc @ayushtkn @tasanuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
