shameersss1 commented on code in PR #6615:
URL: https://github.com/apache/hadoop/pull/6615#discussion_r1515667380
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/DelegationConstants.java:
##########
@@ -160,6 +160,18 @@ public final class DelegationConstants {
*/
public static final String STS_STANDARD = "sts.amazonaws.com";
+ /**
+ * The format of the STS Endpoint
+ */
+ public static final String STS_ENDPOINT_URI_PATTERN =
"^sts\\..*\\.amazonaws\\.com$";
+
+ /**
+ * Error thrown is the STS endpoint is not of the correct pattern.
+ */
+ public static final String E_INVALID_STS_ENDPOINT_PATTERN =
Review Comment:
Shouldn't this be E_INVALID_STS_ENDPOINT_ERROR_MSG?
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/STSClientFactory.java:
##########
@@ -125,6 +125,14 @@ public static StsClientBuilder builder(
public static StsClientBuilder builder(final AwsCredentialsProvider
credentials,
final Configuration conf, final String stsEndpoint, final String
stsRegion,
final String bucket) throws IOException {
+ // If an STS endpoint is provided and if it is not STS_STANDARD
(sts.amazonaws.com)
+ // it should match E_INVALID_STS_ENDPOINT_PATTERN.
Review Comment:
Shouldn't this be STS_ENDPOINT_URI_PATTERN ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
