zhuzilong2013 commented on code in PR #6518:
URL: https://github.com/apache/hadoop/pull/6518#discussion_r1518555454
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -1582,6 +1582,10 @@ void startStandbyServices(final Configuration conf,
boolean isObserver)
standbyCheckpointer = new StandbyCheckpointer(conf, this);
standbyCheckpointer.start();
}
+ if (isNoManualAndResourceLowSafeMode()) {
+ LOG.info("Standby should not enter safe mode when resources are low,
exiting safe mode.");
+ leaveSafeMode(false);
Review Comment:
I reused the logic from
[HDFS-17231](https://issues.apache.org/jira/browse/HDFS-17231), and I believe
there is no issue. HDFS-17231 enables the ANN to automatically exit
ResourceLowSafeMode.
At the same time, I noticed that the 'leaveSafeMode(false)' method also
exits 'StartupSafeMode'. I'm not sure if this is an issue; I mentioned this
phenomenon in [HDFS-17402](https://issues.apache.org/jira/browse/HDFS-17402).
If necessary, I can fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
