KeeProMise commented on code in PR #6622:
URL: https://github.com/apache/hadoop/pull/6622#discussion_r1521225842
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/task/reduce/TestMerger.java:
##########
@@ -229,6 +232,14 @@ public void testInMemoryAndOnDiskMerger() throws Throwable
{
Assert.assertEquals(0, mergeManager.inMemoryMapOutputs.size());
Assert.assertEquals(0, mergeManager.inMemoryMergedMapOutputs.size());
Assert.assertEquals(0, mergeManager.onDiskMapOutputs.size());
+
+ jobConf.set("mapreduce.task.io.sort.factor", "1");
+ thrown.expectMessage("Invalid value for mapreduce.task.io.sort.factor: 1,"
+
+ " please set it to a number greater than 1");
+ thrown.expect(IllegalArgumentException.class);
+ new MergeManagerImpl<Text, Text>(reduceId2, jobConf, fs, lda,
Reporter.NULL, null,
+ null, null, null, null,
+ null, null, new Progress(), new MROutputFiles());
Review Comment:
done
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/task/reduce/TestMerger.java:
##########
@@ -229,6 +232,14 @@ public void testInMemoryAndOnDiskMerger() throws Throwable
{
Assert.assertEquals(0, mergeManager.inMemoryMapOutputs.size());
Assert.assertEquals(0, mergeManager.inMemoryMergedMapOutputs.size());
Assert.assertEquals(0, mergeManager.onDiskMapOutputs.size());
+
+ jobConf.set("mapreduce.task.io.sort.factor", "1");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
