anmolanmol1234 commented on code in PR #6314:
URL: https://github.com/apache/hadoop/pull/6314#discussion_r1528015201
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -700,6 +698,18 @@ public synchronized void close() throws IOException {
if (isClosed) {
return;
}
+ if (abfsStore.getClient().isMetricCollectionEnabled()) {
+ TracingContext tracingMetricContext = new TracingContext(
+ clientCorrelationId,
+ fileSystemId, FSOperationType.GET_ATTR, true,
Review Comment:
This is mainly because the fileystem id is private to the fileystem class,
hence cannot be used in the client class for a unique identifier. Hence we have
used hostname for the identifier in the client class. If this looks as a
disparity, we can make both the tracing contexts use the hostname.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
