[
https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829858#comment-17829858
]
ASF GitHub Bot commented on HADOOP-19120:
-----------------------------------------
anmolanmol1234 commented on code in PR #6633:
URL: https://github.com/apache/hadoop/pull/6633#discussion_r1535496869
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsApacheHttpClient.java:
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.IOException;
+
+import org.apache.hadoop.fs.azurebfs.AbfsConfiguration;
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.HttpRequestBase;
+import org.apache.http.config.Registry;
+import org.apache.http.config.RegistryBuilder;
+import org.apache.http.conn.socket.ConnectionSocketFactory;
+import org.apache.http.conn.socket.PlainConnectionSocketFactory;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.impl.client.HttpClients;
+
+import static
org.apache.http.conn.ssl.SSLConnectionSocketFactory.getDefaultHostnameVerifier;
+
+public class AbfsApacheHttpClient {
+ private final CloseableHttpClient httpClient;
+
+ private final AbfsConfiguration abfsConfiguration;
+
+ public AbfsApacheHttpClient(DelegatingSSLSocketFactory
delegatingSSLSocketFactory,
+ final AbfsConfiguration abfsConfiguration) {
+ this.abfsConfiguration = abfsConfiguration;
+ final AbfsConnectionManager connMgr = new AbfsConnectionManager(
+ createSocketFactoryRegistry(
+ new SSLConnectionSocketFactory(delegatingSSLSocketFactory,
+ getDefaultHostnameVerifier())),
+ new org.apache.hadoop.fs.azurebfs.services.AbfsConnFactory());
+ final HttpClientBuilder builder = HttpClients.custom();
+ builder.setConnectionManager(connMgr)
+ .setRequestExecutor(new AbfsManagedHttpRequestExecutor(
+ abfsConfiguration.getHttpReadTimeout()))
+ .disableContentCompression()
+ .disableRedirectHandling()
+ .disableAutomaticRetries()
+ .setUserAgent(
+ ""); // SDK will set the user agent header in the pipeline. Don't
let Apache waste time
+ httpClient = builder.build();
+ }
+
+ public void close() throws IOException {
+ if (httpClient != null) {
+ httpClient.close();
+ }
+ }
+
+ public HttpResponse execute(HttpRequestBase httpRequest,
+ final AbfsManagedHttpContext abfsHttpClientContext) throws IOException {
+ RequestConfig.Builder requestConfigBuilder = RequestConfig
+ .custom()
+ .setConnectTimeout(abfsConfiguration.getHttpConnectionTimeout())
+ .setSocketTimeout(abfsConfiguration.getHttpReadTimeout());
+ httpRequest.setConfig(requestConfigBuilder.build());
+ return httpClient.execute(httpRequest, abfsHttpClientContext);
+ }
+
+
+ private static Registry<ConnectionSocketFactory> createSocketFactoryRegistry(
+ ConnectionSocketFactory sslSocketFactory) {
+ if (sslSocketFactory == null) {
+ return RegistryBuilder.<ConnectionSocketFactory>create()
+ .register("http", PlainConnectionSocketFactory.getSocketFactory())
Review Comment:
http and https should be read from constant strings
> [ABFS]: ApacheHttpClient adaptation as network library
> ------------------------------------------------------
>
> Key: HADOOP-19120
> URL: https://issues.apache.org/jira/browse/HADOOP-19120
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0
> Reporter: Pranav Saxena
> Assignee: Pranav Saxena
> Priority: Major
> Labels: pull-request-available
>
> Apache HttpClient is more feature-rich and flexible and gives application
> more granular control over networking parameter.
> ABFS currently relies on the JDK-net library. This library is managed by
> OpenJDK and has no performance problem. However, it limits the application's
> control over networking, and there are very few APIs and hooks exposed that
> the application can use to get metrics, choose which and when a connection
> should be reused. ApacheHttpClient will give important hooks to fetch
> important metrics and control networking parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
