zhangshuyan0 commented on code in PR #6653:
URL: https://github.com/apache/hadoop/pull/6653#discussion_r1536763455
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java:
##########
@@ -638,16 +654,22 @@ private static class RenameOperation {
private final byte[] srcChildName;
private final boolean isSrcInSnapshot;
private final boolean srcChildIsReference;
- private final QuotaCounts oldSrcCounts;
+ private final QuotaCounts oldSrcCountsInSnapshot;
+ private final boolean sameStoragePolicy;
+ private final Optional<QuotaCounts> srcSubTreeCountOp;
Review Comment:
These two variable names end in `Op`, which may cause misunderstandings with
EditLogOp. How about calling it srcSubTreeCounts direcly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
