wzk784533 opened a new pull request, #6666: URL: https://github.com/apache/hadoop/pull/6666
Description of PR https://issues.apache.org/jira/browse/HADOOP-19111 Removing redundant debug message about client info when sending rpc request,the debug message print client name(which is getName()) twice,this is confusing. like: 2024-03-16 11:58:49,564 DEBUG ipc.Client: :1113 IPC Client (382750013) connection to kdcserver/172.20.10.12:8888 from nn/[[email protected]](mailto:[email protected])IPC Client (382750013) connection to kdcserver/172.20.10.12:8888 from nn/[[email protected]](mailto:[email protected]) sending #0 org.apache.hadoop.hdfs.protocol.ClientProtocol.getListing the debug message above should delete the bold font part (can't set strikethrough like jira,so use bold fond) ### How was this patch tested? The code chaning is easy to understand. And I have it tested in Junit with other cases in local ### For code changes: LOG.debug(getName() + "{} sending #{} {}", getName(), call.id, call.rpcRequest); abut the code above,there are two reasons to change: a: getName() + and the ｛｝placeholder are duplicate b: To avoid String copy, we should use placehold rather than String + -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
