[
https://issues.apache.org/jira/browse/HADOOP-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830326#comment-17830326
]
ASF GitHub Bot commented on HADOOP-19111:
-----------------------------------------
wzk784533 opened a new pull request, #6666:
URL: https://github.com/apache/hadoop/pull/6666
Description of PR
https://issues.apache.org/jira/browse/HADOOP-19111
Removing redundant debug message about client info
when sending rpc request,the debug message print client name(which is
getName()) twice,this is confusing.
like:
2024-03-16 11:58:49,564 DEBUG ipc.Client: :1113 IPC Client (382750013)
connection to kdcserver/172.20.10.12:8888 from
nn/[[email protected]](mailto:[email protected])IPC Client (382750013) connection
to kdcserver/172.20.10.12:8888 from
nn/[[email protected]](mailto:[email protected]) sending #0
org.apache.hadoop.hdfs.protocol.ClientProtocol.getListing
the debug message above should delete the bold font part
(can't set strikethrough like jira,so use bold fond)
### How was this patch tested?
The code chaning is easy to understand. And I have it tested in Junit with
other cases in local
### For code changes:
LOG.debug(getName() + "{} sending #{} {}", getName(),
call.id, call.rpcRequest);
abut the code above,there are two reasons to change:
a: getName() + and the ｛｝placeholder are duplicate
b: To avoid String copy, we should use placehold rather than String +
> ipc client print client info message duplicate
> ----------------------------------------------
>
> Key: HADOOP-19111
> URL: https://issues.apache.org/jira/browse/HADOOP-19111
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Zhongkun Wu
> Priority: Trivial
> Labels: pull-request-available
>
> when sending rpc request,the debug message print clent name twice,this is
> confusing.
> like:
>
> 2024-03-16 11:58:49,564 DEBUG ipc.Client: :1113 {-}{color:#4c9aff}IPC Client
> (382750013) connection to kdcserver/172.20.10.12:8888 from
> nn/[email protected]{color}{-}IPC Client (382750013) connection to
> kdcserver/172.20.10.12:8888 from nn/[email protected] sending #0
> org.apache.hadoop.hdfs.protocol.ClientProtocol.getListing
>
>
> the debug message above should delete the blue infomation with strikethrough
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
