[ 
https://issues.apache.org/jira/browse/HADOOP-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

RocMarshal updated HADOOP-19128:
--------------------------------
    Description: 
There're some classes logging with pure string like 'AMLauncher':
{code:java}
LOG.info("Setting up container " + masterContainer
    + " for AM " + application.getAppAttemptId()); {code}
It would be better use as follows?:
{code:java}
LOG.info("Setting up container {} for AM {}", masterContainer, 
application.getAppAttemptId());  {code}
 




 

> Unified use of placeholder for log calling
> ------------------------------------------
>
>                 Key: HADOOP-19128
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19128
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: RocMarshal
>            Priority: Minor
>
> There're some classes logging with pure string like 'AMLauncher':
> {code:java}
> LOG.info("Setting up container " + masterContainer
>     + " for AM " + application.getAppAttemptId()); {code}
> It would be better use as follows?:
> {code:java}
> LOG.info("Setting up container {} for AM {}", masterContainer, 
> application.getAppAttemptId());  {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to