ferhui commented on code in PR #6654:
URL: https://github.com/apache/hadoop/pull/6654#discussion_r1538685277
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -6120,7 +6121,7 @@ private void updatePipelineInternal(String clientName,
ExtendedBlock oldBlock,
*/
void registerBackupNode(NamenodeRegistration bnReg,
NamenodeRegistration nnReg) throws IOException {
- writeLock();
+ writeLock(FSNamesystemLockMode.FS);
Review Comment:
Why use the different locks in register and release methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]