slfan1989 commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1540513670
##########
dev-support/bin/hadoop.sh:
##########
@@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \
"${modules[@]}" \
- -DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true
-Dcheckstyle.skip=true \
+ -DskipShade -Dsurefire.failIfNoSpecifiedTests=false -Dtest=NoUnitTests
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \
Review Comment:
I carefully readed the build report, and
`-Dsurefire.failIfNoSpecifiedTests=false` is necessary because we have some
modules without JUnit tests. We use `-Dtest=NoUnitTests` to handle this, which
can cause an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
