[
https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831196#comment-17831196
]
ASF GitHub Bot commented on HADOOP-19102:
-----------------------------------------
saxenapranav commented on PR #6617:
URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2022125533
Hi @steveloughran, thank you very much for the suggestion. Have taken it. As
part of the change, I have the following changes:
1. Added a new util class `AbfsInputStreamTestUtils` which contains the util
methods in ITestAbfsStream for which this class was inherited in
`ITestAbfsInputStreamReadFooter`. Now, ITestAbfsInputStreamReadFooter doesnt
need to inherit ITestAbfsStream.
2. ITestAbfsStreamReadFooter now inherits AbstractAbfsScaleTest.
3. Removed inheritence of ITestAbfsInputStream from
ITestAbfsInputStreamSmallFileReads as it was only inheriting it for the util
methods.
Thank you very much for the suggestions, requesting your kind review. Thank
you a lot!
> [ABFS]: FooterReadBufferSize should not be greater than readBufferSize
> ----------------------------------------------------------------------
>
> Key: HADOOP-19102
> URL: https://issues.apache.org/jira/browse/HADOOP-19102
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Pranav Saxena
> Assignee: Pranav Saxena
> Priority: Major
> Labels: pull-request-available
>
> The method `optimisedRead` creates a buffer array of size `readBufferSize`.
> If footerReadBufferSize is greater than readBufferSize, abfs will attempt to
> read more data than the buffer array can hold, which causes an exception.
> Change: To avoid this, we will keep footerBufferSize =
> min(readBufferSizeConfig, footerBufferSizeConfig)
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
