ferhui commented on code in PR #6589:
URL: https://github.com/apache/hadoop/pull/6589#discussion_r1542703171
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java:
##########
@@ -982,6 +982,11 @@ public final long computeFileSizeNotIncludingLastUcBlock()
{
* if includesLastUcBlock == false.
* @return file size
*/
+ // ComputeFileSize only needs the FSLock even through it involves block.
Review Comment:
can add new comments into the above comment scope?
e.g. below 'Compute file size of the current file.'
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java:
##########
@@ -1998,6 +1998,7 @@ FileStatus getAuditFileInfo(INodesInPath iip)
if (inode.isFile()) {
final INodeFile fileNode = inode.asFile();
+ // Depends on status of the last block
Review Comment:
do you mean it needs to hold lock here?
Can add more comments here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
