Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

[via GitHub]

xiaojunxiang2023 commented on code in PR #6685:
URL: https://github.com/apache/hadoop/pull/6685#discussion_r1546157919


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java:
##########
@@ -749,6 +749,8 @@ void addToReplicasMap(ReplicaMap volumeMap, File dir,
             lazyWriteReplicaMap, isFinalized, exceptions, subTaskQueue);
         subTask.fork();
         subTaskQueue.add(subTask);
+      } else if (isFinalized && ++scanBlockCnt % 10000 == 0) {
+        LOG.info((scanBlockCnt - 1) + " blocks (finalize state) have been 
scanned.");

Review Comment:
   > The log style is not easy to view.
   
   I have optimize it: 
   ![Uploading image.png…]()
   



##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java:
##########
@@ -749,6 +749,8 @@ void addToReplicasMap(ReplicaMap volumeMap, File dir,
             lazyWriteReplicaMap, isFinalized, exceptions, subTaskQueue);
         subTask.fork();
         subTaskQueue.add(subTask);
+      } else if (isFinalized && ++scanBlockCnt % 10000 == 0) {
+        LOG.info((scanBlockCnt - 1) + " blocks (finalize state) have been 
scanned.");

Review Comment:
   > The log style is not easy to view.
   
   I have optimize it: 
   
![image](https://github.com/apache/hadoop/assets/65019264/eb50cd49-2c0f-439d-8989-3252477fea71)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org