pjfanning commented on PR #6557: URL: https://github.com/apache/hadoop/pull/6557#issuecomment-2035365011
> looks good, I am worried about overloaded methods though -we've had so many problems there in the past. the new method is good (one extra resilience change proposed) -but should we still use intercept() or give it a slightly different name. > > we lifted the name from ScalaTest, if you've never played with that yet. I am very familiar with Scala test. I code mainly in Scala. Junit has assertThrows though. Would that be a bit more Java friendly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
