slfan1989 commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1550647039
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -1089,13 +1089,7 @@ public DatanodeInfo[]
getDatanodeReport(DatanodeReportType type)
DatanodeInfo[] getCachedDatanodeReport(DatanodeReportType type)
throws IOException {
try {
- DatanodeInfo[] dns = this.dnCache.get(type);
- if (dns == null) {
- LOG.debug("Get null DN report from cache");
- dns = getCachedDatanodeReportImpl(type);
- this.dnCache.put(type, dns);
- }
- return dns;
+ return this.dnCache.get(type);
Review Comment:
Thank you for your contribution! but I am not sure that this modification is
correct. I need other partners to help review.
@ayushtkn @goiri Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
