mukund-thakur commented on code in PR #5081:
URL: https://github.com/apache/hadoop/pull/5081#discussion_r1552222497
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFSMainOperations.java:
##########
@@ -58,6 +60,15 @@ public void tearDown() throws Exception {
}
}
+ @Test
+ @Override
+ public void testWDAbsolute() throws IOException {
+ Path absoluteDir = getTestRootPath(fSys, "test/existingDir");
Review Comment:
could you please explain this test a bit more.
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md:
##########
@@ -43,7 +43,7 @@ is a more specific lie and harder to make. And, if you get
caught out: you
lose all credibility with the project.
You don't need to test from a VM within the AWS infrastructure; with the
-`-Dparallel=tests` option the non-scale tests complete in under ten minutes.
+`-Dparallel=tests` option the non-scale tests complete in under twenty minutes.
Review Comment:
nit: typo: parallel-tests
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java:
##########
@@ -113,6 +113,16 @@ public void setup() throws Exception {
DEFAULT_HUGE_FILESIZE);
}
+ /**
+ * Test dir deletion is removed from test case teardown so the
+ * subsequent tests see the output.
+ * @throws IOException failure
+ */
+ @Override
+ protected void deleteTestDirInTeardown() throws IOException {
Review Comment:
So for the huge files test, we will have to delete manually via the S3
lifecycle rule as mentioned in the testting.doc?
This is just to reduce the time taken by tests right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
