tomicooler commented on code in PR #6771:
URL: https://github.com/apache/hadoop/pull/6771#discussion_r1579096249
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c:
##########
@@ -242,8 +242,8 @@ static int write_pid_to_cgroup_as_root(const char*
cgroup_file, pid_t pid) {
strerror(errno));
rc = -1;
goto cleanup;
- } else if (buf.f_type != CGROUP_SUPER_MAGIC) {
- fprintf(LOGFILE, "Pid file %s is not located on cgroup filesystem\n",
cgroup_file);
+ } else if (buf.f_type != CGROUP_SUPER_MAGIC || buf.f_type !=
CGROUP2_SUPER_MAGIC) {
Review Comment:
https://docs.kernel.org/admin-guide/cgroup-v2.html
It should come from
https://github.com/torvalds/linux/blob/v4.6/include/uapi/linux/magic.h#L58
which we include, probably it is an old kernel.
Could be fixed with:
```
#ifndef CGROUP2_SUPER_MAGIC
#define CGROUP2_SUPER_MAGIC 0x63677270
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
