steveloughran commented on code in PR #6531:
URL: https://github.com/apache/hadoop/pull/6531#discussion_r1481361766
##########
hadoop-project/pom.xml:
##########
@@ -168,7 +168,18 @@
<enforced.maven.version>[3.3.0,)</enforced.maven.version>
<!-- Plugin versions and config -->
- <maven-surefire-plugin.argLine>-Xmx2048m
-XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
+ <maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
Review Comment:
anyway, regarding this line: the exports thing is java11+ only, right? so it
should only be set on java11+.
proposed: add a java17 profile and set some maven.surefire.java17.options
string to it there, on the default java8 profile set it to ""
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
