steveloughran commented on code in PR #6445:
URL: https://github.com/apache/hadoop/pull/6445#discussion_r1581316396
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java:
##########
@@ -150,7 +150,9 @@ public static Compressor getCompressor(CompressionCodec
codec, Configuration con
Compressor compressor = borrow(compressorPool, codec.getCompressorType());
if (compressor == null) {
compressor = codec.createCompressor();
- LOG.info("Got brand-new compressor ["+codec.getDefaultExtension()+"]");
+ if(LOG.isDebugEnabled()) {
Review Comment:
actually we can move to full slf4j here, so
```
LOG.debug("Got brand-new compressor [{}]", codec.getDefaultExtension());
```
I've looked at the codecs and apart from one case, `PassthroughCodec`, this
is all a low cost invocation so no need to wrap. but that does log at info.
so there is a good argument for guarding the logging.
but: can you add a space between the `if` and the `(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
