[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841393#comment-17841393 ]
ASF GitHub Bot commented on HADOOP-19134: ----------------------------------------- hadoop-yetus commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2080325011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 31s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 56 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 14m 20s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 32m 9s | | trunk passed | | +1 :green_heart: | compile | 17m 26s | | trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 | | +1 :green_heart: | compile | 16m 30s | | trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | +1 :green_heart: | checkstyle | 4m 48s | | trunk passed | | +1 :green_heart: | mvnsite | 20m 4s | | trunk passed | | +1 :green_heart: | javadoc | 17m 42s | | trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 | | +1 :green_heart: | javadoc | 17m 37s | | trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | +1 :green_heart: | spotbugs | 31m 4s | | trunk passed | | +1 :green_heart: | shadedclient | 34m 24s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 11m 45s | | the patch passed | | +1 :green_heart: | compile | 16m 58s | | the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 | | +1 :green_heart: | javac | 16m 58s | | the patch passed | | +1 :green_heart: | compile | 16m 19s | | the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | +1 :green_heart: | javac | 16m 19s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 4m 54s | [/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/artifact/out/results-checkstyle-root.txt) | root: The patch generated 7 new + 3898 unchanged - 62 fixed = 3905 total (was 3960) | | +1 :green_heart: | mvnsite | 20m 11s | | the patch passed | | +1 :green_heart: | javadoc | 17m 44s | | the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 | | +1 :green_heart: | javadoc | 17m 38s | | the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | +1 :green_heart: | spotbugs | 35m 42s | | the patch passed | | +1 :green_heart: | shadedclient | 34m 29s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 19m 38s | | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 3m 54s | | hadoop-kms in the patch passed. | | +1 :green_heart: | unit | 229m 0s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | unit | 1m 27s | | hadoop-yarn-api in the patch passed. | | +1 :green_heart: | unit | 6m 7s | | hadoop-yarn-common in the patch passed. | | +1 :green_heart: | unit | 4m 1s | | hadoop-yarn-server-common in the patch passed. | | +1 :green_heart: | unit | 106m 1s | | hadoop-yarn-server-resourcemanager in the patch passed. | | +1 :green_heart: | unit | 24m 46s | | hadoop-yarn-server-nodemanager in the patch passed. | | +1 :green_heart: | unit | 28m 51s | | hadoop-yarn-client in the patch passed. | | +1 :green_heart: | unit | 7m 51s | | hadoop-mapreduce-client-core in the patch passed. | | +1 :green_heart: | unit | 1m 41s | | hadoop-mapreduce-client-common in the patch passed. | | +1 :green_heart: | unit | 9m 6s | | hadoop-mapreduce-client-app in the patch passed. | | +1 :green_heart: | unit | 4m 40s | | hadoop-mapreduce-client-hs in the patch passed. | | +1 :green_heart: | unit | 127m 45s | | hadoop-mapreduce-client-jobclient in the patch passed. | | +1 :green_heart: | unit | 24m 55s | | hadoop-distcp in the patch passed. | | +1 :green_heart: | unit | 1m 19s | | hadoop-yarn-server-router in the patch passed. | | +1 :green_heart: | unit | 1m 34s | | hadoop-mapreduce-examples in the patch passed. | | +1 :green_heart: | unit | 7m 32s | | hadoop-streaming in the patch passed. | | +1 :green_heart: | unit | 1m 10s | | hadoop-rumen in the patch passed. | | +1 :green_heart: | unit | 1m 16s | | hadoop-datajoin in the patch passed. | | +1 :green_heart: | unit | 3m 35s | | hadoop-aws in the patch passed. | | +1 :green_heart: | asflicense | 1m 31s | | The patch does not generate ASF License warnings. | | | | 1012m 25s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6692 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 1ae0aa4485bb 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 5a0cf37ad0b8377d810fe8e99327cf65058b4fd3 | | Default Java | Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/testReport/ | | Max. process+thread count | 3929 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > use StringBuilder instead of StringBuffer > ----------------------------------------- > > Key: HADOOP-19134 > URL: https://issues.apache.org/jira/browse/HADOOP-19134 > Project: Hadoop Common > Issue Type: Improvement > Reporter: PJ Fanning > Priority: Major > Labels: pull-request-available > > StringBuilder is basically the same as StringBuffer but doesn't use > synchronized. String appending rarely needs locking like this. > There are some public and package private APIs that use StringBuffers as > input or return types - I have left these alone for compatibility reasons. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org