haiyang1987 commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1582072552
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2091,14 +2092,16 @@ public void unfinalizeBlock(ExtendedBlock b) throws
IOException {
* @param info the replica that needs to be deleted
* @return true if data for the replica are deleted; false otherwise
*/
- private boolean delBlockFromDisk(ReplicaInfo info) {
+ private boolean delBlockFromDisk(ReplicaInfo info, String bpid) {
if (!info.deleteBlockData()) {
- LOG.warn("Not able to delete the block data for replica " + info);
+ LOG.warn("Not able to delete the block data for replica " + info +
Review Comment:
can update warn("{}", arg) format?
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2091,14 +2092,16 @@ public void unfinalizeBlock(ExtendedBlock b) throws
IOException {
* @param info the replica that needs to be deleted
* @return true if data for the replica are deleted; false otherwise
*/
- private boolean delBlockFromDisk(ReplicaInfo info) {
+ private boolean delBlockFromDisk(ReplicaInfo info, String bpid) {
if (!info.deleteBlockData()) {
- LOG.warn("Not able to delete the block data for replica " + info);
+ LOG.warn("Not able to delete the block data for replica " + info +
+ " bpid:" + bpid);
return false;
} else { // remove the meta file
if (!info.deleteMetadata()) {
- LOG.warn("Not able to delete the meta data for replica " + info);
+ LOG.warn("Not able to delete the meta data for replica " + info +
Review Comment:
here
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2016,7 +2016,7 @@ private ReplicaInfo finalizeReplica(String bpid,
ReplicaInfo replicaInfo)
if (volumeMap.get(bpid, replicaInfo.getBlockId()).getGenerationStamp()
> replicaInfo.getGenerationStamp()) {
throw new IOException("Generation Stamp should be monotonically "
Review Comment:
```
throw new IOException("Generation Stamp should be monotonically "
+ "increased for bpid: " + bpid + " , block: " + replicaInfo);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
